dosubot[bot] commented on issue #36258: URL: https://github.com/apache/superset/issues/36258#issuecomment-3574235635
<!-- Answer --> You are correct: the Server Page Length control is currently missing the legacyValidateInteger validator, which is why it doesn't show the "is expected to be an integer" error tooltip for non-integer values, unlike the Row limit control. In the code, Row limit includes legacyValidateInteger (and other validators), but Server Page Length does not have any validators applied. You can fix this by adding legacyValidateInteger to the validators array for the Server Page Length control in the table chart's control panel config. This will ensure both fields behave consistently and display the appropriate error tooltip for invalid input. [See the relevant code here.](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx#L399-L452) <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/0fd8fb43-8a52-4111-894a-e597d8d4bf2c?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github) [](https://cursor.com/link/prompt?text=You%20are%20correct%3A%20the%20Server%20Page%20Length%20control%20is%20currently%20missing%20the%20legacyValidateInteger%20validator%2C%20which%20is%20why%20it%20doesn%27t%20show%20the%20%22is%20expected%20to%20be%20an%20integer%22%20error%20tooltip%20for%20non-integer%20values%2C%20unlike%20the%20Row%20limit%20control.%20In%20the%20code%2C%20Row%20limit%20includes%20legacyValidateInteger%20%28and%20other%20validators%29%2C%20but%20Server%20Page%20Length%20does%20not%20have%20any%20validators%20applied.%20You%20can%20fix%20this%20by%20adding%20legacyValidateInteger%20to%20the%20validators%20array%20for%20the%20Server%20Page%20Length%20control%20in%20the%20table%20chart%27s%20control%20panel%20config.%20This%20will%20ensure%20both%20fields%20behave% 20consistently%20and%20display%20the%20appropriate%20error%20tooltip%20for%20invalid%20input.%20%20%0A%5BSee%20the%20relevant%20code%20here.%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx%23L399-L452%29) [](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/36258) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
