aminghadersohi commented on code in PR #36271:
URL: https://github.com/apache/superset/pull/36271#discussion_r2561031166


##########
superset/mcp_service/chart/tool/get_chart_info.py:
##########
@@ -41,7 +41,7 @@
 @mcp_auth_hook
 @parse_request(GetChartInfoRequest)
 async def get_chart_info(
-    request: GetChartInfoRequest, ctx: Context
+    request: str | GetChartInfoRequest, ctx: Context

Review Comment:
   hey bito, you are right, but we need the `str |` so llms like claude code 
can be allowed to pass a json string. They are having trouble calling it when 
its just pydantic. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to