bito-code-review[bot] commented on code in PR #36300:
URL: https://github.com/apache/superset/pull/36300#discussion_r2566619407
##########
docs/yarn.lock:
##########
@@ -10018,9 +10018,9 @@ node-fetch-commonjs@^3.3.2:
web-streams-polyfill "^3.0.3"
node-forge@^1:
- version "1.3.1"
- resolved
"https://registry.yarnpkg.com/node-forge/-/node-forge-1.3.1.tgz#be8da2af243b2417d5f646a770663a92b7e9ded3";
- integrity
sha512-dPEtOeMvF9VMcYV/1Wb8CPoVAXtp6MKMlcbAt4ddqmGqUJ6fQZFXkNZNkNlfevtNkGtaSoXf/vNNNSvgrdXwtA==
+ version "1.3.2"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Update CI allowlist for node-forge security fix</b></div>
<div id="fix">
The node-forge dependency update from 1.3.1 to 1.3.2 addresses
CVE-2025-12816, a critical signature verification bypass vulnerability that
could allow attackers to bypass authentication or tamper with signed data.
However, the CI dependency review workflow in
`.github/workflows/dependency-review.yml` still only allows version 1.3.1,
which will cause the build to fail. Update the `allow-dependencies-licenses`
configuration to include `pkg:npm/[email protected]` to ensure CI passes and the
security fix can be deployed.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- allow-dependencies-licenses: pkg:npm/[email protected],
pkg:npm/applitools/core, pkg:npm/applitools/core-base,
pkg:npm/applitools/css-tree, pkg:npm/applitools/ec-client,
pkg:npm/applitools/eg-socks5-proxy-server, pkg:npm/applitools/eyes,
pkg:npm/applitools/eyes-cypress, pkg:npm/applitools/nml-client,
pkg:npm/applitools/tunnel-client, pkg:npm/applitools/utils,
pkg:npm/[email protected], pkg:npm/rgbcolor, pkg:npm/[email protected]
+ allow-dependencies-licenses: pkg:npm/[email protected],
pkg:npm/applitools/core, pkg:npm/applitools/core-base,
pkg:npm/applitools/css-tree, pkg:npm/applitools/ec-client,
pkg:npm/applitools/eg-socks5-proxy-server, pkg:npm/applitools/eyes,
pkg:npm/applitools/eyes-cypress, pkg:npm/applitools/nml-client,
pkg:npm/applitools/tunnel-client, pkg:npm/applitools/utils,
pkg:npm/[email protected], pkg:npm/rgbcolor, pkg:npm/[email protected]
```
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/36300#issuecomment-3583376466>#60fd9d</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
