etr2460 opened a new pull request #7791: Improve performance for add slice container URL: https://github.com/apache/incubator-superset/pull/7791 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The dropdown for the add slice page was super slow and laggy, and too small to fit the full table name. The slowness issue was due to `ignoreAccents` being set to true (details here: https://github.com/JedWatson/react-select/issues/3128). Datasource names should rarely have accented characters, so I think this is a fine fix ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable -->  ### TEST PLAN <!--- What steps should be taken to verify the changes --> Test and see much better performance ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @graceguo-supercat
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
