Vitor-Avila commented on PR #36247: URL: https://github.com/apache/superset/pull/36247#issuecomment-3586423299
@betodealmeida will have to revert to fixing this at the AG Grid level. Dashboard native filters intentionally set `metrics=[]` and expect an aggregation. Personally, I think this is confusing (I understand the need to be able to aggregate without any metric, but I would expect something more explicit instead of just `metrics=[]`), but changing this would be a larger refactor. We used to have both `groupby` and `columns` but it was deprecated and unified [in this PR](https://github.com/apache/superset/pull/16660), which makes sense I agree we can call both use-cases as `columns`. Ideally, instead of using `metrics=[]` we would rely on something like `QueryMode`, but I don't think native filters use that. Long-term, I could see native filters having their own dedicated endpoint to avoid the need to comply with the complexity of `/api/v1/chart/data` but that's also a larger effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
