amym-li opened a new pull request, #36314:
URL: https://github.com/apache/superset/pull/36314
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
To migrate the Tab component, the following steps were performed:
1. Renamed the index file from `index.js` => `index.ts`
2. Renamed the component file from `Tab.jsx` => `Tab.tsx`
3. In `Tab.tsx`
- Replaced the `propTypes` const with an `interface TabProps` definition
- Typed callbacks and handlers to their expected values
4. In `Tab.test.tsx`,
- Imported `RENDER_TAB` and `RENDER_TAB_CONTENT` from `Tab.tsx`
- In `createProps` function, casted `component` and `parentComponent`
properties to `LayoutItem` type
5. In `DashboardComponent.jsx`,
- Added missing properties to `propTypes` const
6. In `types.ts`,
- Added missing properties to the `DashboardState` and `LayoutItemMeta`
types
7. Resolved type errors
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="587" height="111" alt="image"
src="https://github.com/user-attachments/assets/015bdc40-0bd4-4a41-b0eb-3b810ba133af";
/>
<img width="364" height="92" alt="image"
src="https://github.com/user-attachments/assets/df399728-4d8e-4a99-a443-ab39c5a87faf";
/>
After:
<img width="531" height="107" alt="image"
src="https://github.com/user-attachments/assets/a7d68af2-efb5-4959-8d2d-c547c0038278";
/>
<img width="339" height="97" alt="image"
src="https://github.com/user-attachments/assets/296e8e6f-d8a9-4bde-b625-6abfb118fe12";
/>
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
CI and unit tests. Add a Tabs layout element to a dashboard and confirm that
adding/editing/removing a tab works as expected.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/9101
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
to: @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
