rusackas commented on PR #36201: URL: https://github.com/apache/superset/pull/36201#issuecomment-3590228259
Thanks for adding all the feature-flag checks. I guess what I'm wondering now, looking at it again, is if we _overcorrected_ here. Should parts of this work without the Javascript Controls feature flag turned on? I.e. Should I still be able to pick an icon URL, adjust size, or maybe use some of the other inputs (color, etc.)? If some of these new features work without Javascript inptus, that would be nice to leave those features enabled. I was under the impression that the JS inputs just add _even more_ flexibility, and were somewhat optional. Correct me if I'm misunderstanding :) Would love to be able to use as much of this as possible in deployments where JS controls are disabled (e.g. Preset, and... probably lots of others) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
