amym-li opened a new pull request, #36335: URL: https://github.com/apache/superset/pull/36335
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> To migrate the Divider component, the following steps were performed: 1. Renamed the index file from `index.js` => `index.ts` 2. Renamed the component file from `Divider.jsx` => `Divider.tsx` 3. Made the following type changes in `Divider.tsx`: - Replaced the `propTypes` const with an `interface DividerProps` definition - Typed callbacks and functions to their expected values 4. Renamed the test file from `Divider.test.jsx` => `Divider.test.tsx` 5. Made the following type changes in `Divider.test.tsx` - Typed the `props` const to `DividerProps` - Typed callbacks and functions to their expected values 6. Resolved eslint warnings and errors. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> CI and unit tests. Add a Divider layout element to a dashboard and confirm that it renders as expected. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/9101 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @rusackas @msyavuz @justinpark @sadpandajoe @geido -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
