danawan0409 opened a new pull request, #36347: URL: https://github.com/apache/superset/pull/36347
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY To migrate the **Row** component, the following steps were performed: - Renamed the index file from **`index.js` ⇒ `index.ts`** - Renamed the component file from **`Row.jsx` ⇒ `Row.tsx`** - Made the following type changes in `Row.tsx`: - Replaced the `propTypes` constant with an **type RowProps`** - Typed callbacks and functions to their expected values - Renamed the test file from **`Row.test.jsx` ⇒ `Row.test.tsx`** - Added the following type changes in `Row.test.tsx`: - Created **interface `RowTestProps`** mirroring `RowProps` from `Row.tsx` - Renamed the test file from **`NewRow.jsx` ⇒ `NewRow.tsx`** - Renamed the test file from **`NewRow.test.jsx` ⇒ `NewRow.test.tsx`** - Addressed all ESLint warnings and TypeScript errors ### TESTING INSTRUCTIONS CI and unit tests. Add a Rowlayout element to a dashboard and confirm that it renders as expected. ### ADDITIONAL INFORMATION - [x] Has associated issue: **[SIP-36] Proposal for standardizing use of TypeScript #9101** - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API ## REVIEWERS @rusackas @msyavuz @justinpark @sadpandajoe @geido -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
