dserkowski opened a new pull request #7796: Added possibility to translate the 
phrase 'No results found' in FilterBox
URL: https://github.com/apache/incubator-superset/pull/7796
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   I am currently working on a translation of your system to Portuguese. This 
is one of the enhancements that can be applicable to the core project.
   Basically, the changes add the possibility to translate the phrase 'No 
results found', which we can see when we use FilterBox in a report. When no 
option is available in select boxes of FilterBox, the phrase is displayed. The 
current implementation does not translate the phrase even if we add the message 
to messages.json (message.po) and we select the appropriate application 
language.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   If we apply this contribution and we modify language messages, eg. 
Portuguese one, we can see something like this:
   
![peek1](https://user-images.githubusercontent.com/29867015/60344509-04329700-99b7-11e9-85b5-4947d573aa55.gif)
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to