rusackas commented on code in PR #36288:
URL: https://github.com/apache/superset/pull/36288#discussion_r2578192310
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -30,6 +30,7 @@ import {
Loading,
type EmptyStateProps,
} from '@superset-ui/core/components';
+import { Pagination } from 'antd';
Review Comment:
This should have been caught by an eslint/oxc rule (I'll look into that),
but we should be importing from.
We should definitely not import antd components directly, and should
probably re-export the antd component from our shared components, for use in
other parts of Superset (so we can style it centrally, or do whatever's needed
to keep things consistent).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
