dpgaspar commented on issue #7665: [WiP] [api] [database] New, migrate to new 
FAB API side by side
URL: 
https://github.com/apache/incubator-superset/pull/7665#issuecomment-506779514
 
 
   Made a major change on database and views module reorganization.
   
   This is still very much a work in progress, @mistercrunch take a look and 
see if you agree.
   I would personally end with the `views` module, and would create modules by 
function, using the following structure:
   
   ```
   superset/
       database/
          __init__.py
          views.py
          api.py
          forms.py
          models.py (putting the models here is organized, but is highly 
debatable)
   ``` 
   
   What I have done on this PR is more conservative:
   ```
   superset/
       views/
           database/
                __init__.py
               views.py
               api.py
               forms.py
   ```
   
   But `superset.views.database.views` is a bit redundant on `views` right?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to