codeant-ai-for-open-source[bot] commented on PR #36332: URL: https://github.com/apache/superset/pull/36332#issuecomment-3604122551
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36332/files#diff-a1256efcca3d8954c815c26f94d13eb86abd3f52c67258071fed1b3ece4a5b00R161-R174'><strong>Possible Bug</strong></a><br>`onDashboardChange` assumes the dashboard argument is always a non-null object, but `AsyncSelect` is configured with `allowClear`, so it may pass `null`/`undefined` when the selection is cleared. The new implementation immediately dereferences `dashboard.value`, which can now throw at runtime when clearing the field. This path needs a null/undefined guard.<br> - [ ] <a href='https://github.com/apache/superset/pull/36332/files#diff-a1256efcca3d8954c815c26f94d13eb86abd3f52c67258071fed1b3ece4a5b00R329-R397'><strong>Possible Bug</strong></a><br>In `addChartToDashboardTab`, the `catch` block calls `new Error('Error adding chart to dashboard tab:', error)`. The `Error` constructor only accepts a single message argument, so the second `error` argument is invalid in TypeScript and will be ignored at runtime. This both causes a type error and drops the original stack/context; the function should either rethrow the original error or wrap it properly.<br> - [ ] <a href='https://github.com/apache/superset/pull/36332/files#diff-9e5762ab474e55120025ca4afd6643fa47dbf2ac56a09f38a0053cf4dc86abc1R47-R50'><strong>Possible Bug</strong></a><br>The mocked `TreeSelect` uses a `data-test` attribute but the tests query using `getByTestId('mock-tree-select')`, which expects `data-testid`. This mismatch will cause all tab selector tests to fail and should be aligned.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
