john-bodley opened a new pull request #7799: [fix] Updating Pandas resample logic URL: https://github.com/apache/incubator-superset/pull/7799 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY This PR updates a number of issues related to the "Advanced Analytics" Pandas resampling logic. Specifically it: 1. Removes empty UI options. 2. Updates the Pandas [resample](https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.resample.html#pandas.Series.resample) logic for `fill_method` and `how` is deprecated. Note previously both `how` (predominantly down-scaling) and `fill_method` (up-scaling) could be used simultaneously which was somewhat misleading. The new resampling logic simply uses a method many of which can be applied when either down- or up-scaling. ### TEST PLAN CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [x] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS to: @michellethomas @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
