john-bodley commented on a change in pull request #7799: [fix] Updating Pandas
resample logic
URL:
https://github.com/apache/incubator-superset/pull/7799#discussion_r298778433
##########
File path: superset/viz.py
##########
@@ -1129,30 +1129,28 @@ def process_data(self, df, aggregate=False):
if fd.get("granularity") == "all":
raise Exception(_("Pick a time granularity for your time series"))
- if not aggregate:
+ if aggregate:
Review comment:
Note I simply flipped these clauses from a readability perspective.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
