sadpandajoe commented on code in PR #36196: URL: https://github.com/apache/superset/pull/36196#discussion_r2583638253
########## superset-frontend/playwright/utils/constants.ts: ########## @@ -0,0 +1,47 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Timeout constants for Playwright tests. + * Only define timeouts that differ from Playwright defaults or are semantically important. + * + * Default Playwright timeouts (from playwright.config.ts): + * - Test timeout: 30000ms (30s) + * - Expect timeout: 8000ms (8s) + * + * Use these constants instead of magic numbers for better maintainability. + */ + +export const TIMEOUT = { + /** + * Page navigation and load timeouts + */ + PAGE_LOAD: 10000, // 10s for page transitions (login → welcome, dataset → explore) Review Comment: Comment only makes sense if we keep it at 30s, but if we ever change the default then would make this obsolete, so I rather just keep what the page load timeout actually is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
