codeant-ai-for-open-source[bot] commented on code in PR #36408:
URL: https://github.com/apache/superset/pull/36408#discussion_r2585054258
##########
docs/docs/configuration/theming.mdx:
##########
@@ -255,26 +256,26 @@ You can also configure ECharts overrides through the
theme CRUD interface:
```json
{
- "token": {
- "colorPrimary": "#2893B3"
- },
- "echartsOptionsOverrides": {
- "grid": {
- "left": "10%",
- "right": "10%"
- },
- "tooltip": {
- "backgroundColor": "rgba(0, 0, 0, 0.8)"
- }
- },
- "echartsOptionsOverridesByChartType": {
- "echarts_pie": {
- "legend": {
- "orient": "vertical",
- "right": 10
- }
+ "token": {
+ "colorPrimary": "#2893B3"
Review Comment:
**Suggestion:** Invalid JSON in the UI configuration example: a missing
comma between `"colorPrimary"` and `"echartsOptionsOverrides"` makes the JSON
block unparseable and will break anyone who copies this JSON into a parser or
configuration file. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
"colorPrimary": "#2893B3",
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The JSON snippet in the docs is missing a comma after "colorPrimary", which
makes the JSON invalid. Fixing it is correct and necessary: it prevents
copy-paste breakage for users and documentation parsers. This is a docs-only
correctness fix.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/configuration/theming.mdx
**Line:** 260:260
**Comment:**
*Possible Bug: Invalid JSON in the UI configuration example: a missing
comma between `"colorPrimary"` and `"echartsOptionsOverrides"` makes the JSON
block unparseable and will break anyone who copies this JSON into a parser or
configuration file.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
##########
docs/docs/configuration/theming.mdx:
##########
@@ -323,40 +324,40 @@ THEME_DEFAULT = {
"token": {
"colorPrimary": "#1B4D3E",
"fontFamily": "Corporate Sans, Arial, sans-serif"
Review Comment:
**Suggestion:** Syntax error in the corporate theme Python example: the
`"fontFamily"` line is missing a trailing comma before the
`"echartsOptionsOverrides"` key, which will cause a runtime SyntaxError if
someone copies this Python snippet into their config. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
"fontFamily": "Corporate Sans, Arial, sans-serif",
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
The Python example in the PR is missing a trailing comma after the
"fontFamily" entry, which will trigger a SyntaxError if someone copies this
into a superset_config.py. The suggested comma is the correct and minimal fix.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** docs/docs/configuration/theming.mdx
**Line:** 326:326
**Comment:**
*Possible Bug: Syntax error in the corporate theme Python example: the
`"fontFamily"` line is missing a trailing comma before the
`"echartsOptionsOverrides"` key, which will cause a runtime SyntaxError if
someone copies this Python snippet into their config.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
