codeant-ai-for-open-source[bot] commented on PR #36263: URL: https://github.com/apache/superset/pull/36263#issuecomment-3609688780
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36263/files#diff-b69349908c886a7fb0924d9c8534d9ffa81a37c09db77a25413916f661d6eaa8R1476-R1482'><strong>Permission existence / naming</strong></a><br>New expected permissions (`can_estimate_query_cost`, `can_format_sql`) must exactly match the permission/view-menu names used when creating permissions in the security manager / FAB roles. Validate that the security role definition and permission creation code actually register view-menus with those exact names and spellings; otherwise the test will fail even if permissions exist under a slightly different name.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
