richardfogaca commented on code in PR #36416:
URL: https://github.com/apache/superset/pull/36416#discussion_r2588539307
##########
tests/unit_tests/datasets/schema_tests.py:
##########
@@ -46,3 +46,47 @@ def test_validate_python_date_format(payload) -> None:
def test_validate_python_date_format_raises(payload) -> None:
with pytest.raises(ValidationError):
validate_python_date_format(payload)
+
+
+def test_dataset_columns_put_schema_includes_currency_code() -> None:
+ """Test that DatasetColumnsPutSchema properly handles is_currency_code
field."""
+ from superset.datasets.schemas import DatasetColumnsPutSchema
+
+ schema = DatasetColumnsPutSchema()
+
+ # Column marked as currency code
+ data = {
+ "column_name": "currency",
+ "is_currency_code": True,
+ }
+ result = schema.load(data)
+ assert result["is_currency_code"] is True
Review Comment:
is_currency_code is not needed, so this column has been removed from stale
tests and types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
