YousufFFFF commented on PR #36306:
URL: https://github.com/apache/superset/pull/36306#issuecomment-3614144484
Hey @rusackas!, I’ve pushed an update:
• Restored selected: undefined in expectedThemeProps.
• Switched the legend tests back to strict toEqual assertions.
• Kept selector / selectorLabel and the All/Inv buttons in both
implementation and tests.
Please let me know if you’d like any other tweaks!
Also, he pre-commit CI seems to have failed on an unrelated step (helm-docs
broken pipe).
My local pre-commit checks and tests are passing.
Could you please re-run or approve the workflow when you get a moment?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
