Re: [PR] refactor(sqllab): Separate left panel outside of tab container [superset]

Fri, 05 Dec 2025 10:04:52 -0800 


kasiazjc commented on PR #36360:
URL: https://github.com/apache/superset/pull/36360#issuecomment-3617940484

   > LGTM. Thanks for addressing the comments @justinpark.
   > 
   > Here's how the feature looks like after the latest changes:
   > 
   > <img alt="Screenshot 2025-12-03 at 08 31 37" width="1719" height="885" 
src="https://private-user-images.githubusercontent.com/70410625/521904061-505762e5-9593-4eb3-9b0a-fcf418a823ac.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NjQ5NTc2MDMsIm5iZiI6MTc2NDk1NzMwMywicGF0aCI6Ii83MDQxMDYyNS81MjE5MDQwNjEtNTA1NzYyZTUtOTU5My00ZWIzLTliMGEtZmNmNDE4YTgyM2FjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTEyMDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUxMjA1VDE3NTUwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2YmNjNWE2Njk2ZTY4NGMwYzc5YmFiMjNjMzNjN2M1MWE4MjU5MDAyZTM2M2UwZDFmZTgyNzQ3ZjJiNTg0OTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Cc27zXW9YFdTJrlSRX6UiwIUTHy5f3BFnI-_KuyQvAQ";>
   > Non-blocking:
   > 
   > Personally, I prefer the auto option for the collapsible icon but I'm not 
sure if it becomes to hard for people to find it. Maybe @kasiazjc can help us 
here. We can also change this setting in a follow-up if needed.
   > 
   >  Screen.Recording.2025-12-03.at.08.35.29.mov
   
   So when it comes to the collapse icon I have a few thoughts:
   1. the one in the PR description I am not the biggest fan of especially, 
because it is styled like primary button and it interferes with hierarchy - 
seems like an important action and it's just a collapse trigger 
   2. I like the one @michael-s-molina suggested - I think what can help with 
discoverability is anchoring it to the top (in line with first label I think) 
instead of the middle. 
   
   So for me the second option makes more sense :) 
   
   This proposes though a bigger question of collapsible panels - we also use 
it in explore (dataset details) and dashboards (filters) and would be perfect 
if possible to change it all at once so that we use the same patterns across 
the whole app 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to