bito-code-review[bot] commented on code in PR #36444:
URL: https://github.com/apache/superset/pull/36444#discussion_r2594337751
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -502,7 +502,7 @@ export function ListView<T extends object = any>({
size="large"
image="filter-results.svg"
buttonAction={() => handleClearFilterControls()}
- buttonText={t('clear all filters')}
+ buttonText={t('Clear all filters')}
/>
) : (
<EmptyState
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>I18n breakage from key mismatch</b></div>
<div id="fix">
This change capitalizes the translation key from 'clear all filters' to
'Clear all filters', but existing translation files (.po) use the lowercase
msgid. This will cause the button text to appear untranslated in non-English
locales, breaking i18n. Other button texts like 'Deselect all' and 'Add Tag'
are capitalized in both code and translations, suggesting consistency is
desired, but translations must be updated accordingly.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
size="large"
image="filter-results.svg"
buttonAction={() => handleClearFilterControls()}
buttonText={t('clear all filters')}
/>
) : (
<EmptyState
````
</div>
</details>
</div>
<small><i>Code Review Run #4ab9e8</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
