greggailly commented on code in PR #36071:
URL: https://github.com/apache/superset/pull/36071#discussion_r2595022256
##########
superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.tsx:
##########
@@ -254,7 +254,7 @@ describe('PropertiesModal', () => {
expect(screen.getByText('Certification')).toBeInTheDocument();
// General information section is expanded by default
- expect(screen.getAllByRole('textbox')).toHaveLength(2); // Name and Slug
are visible
+ expect(screen.getAllByRole('textbox')).toHaveLength(3); // Name, Slug and
Description are visible
Review Comment:
Could be done (not tested) but it this case I would not do it (in my
opinion) in the same PR just for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
