murphylee10 commented on PR #36348: URL: https://github.com/apache/superset/pull/36348#issuecomment-3623158392
> Let's also add the package as an optional dependency here: > > https://github.com/apache/superset/blob/a18b62cf6b82c0ba73902941d5c4f807baa25016/pyproject.toml#L114 > > Something like: > > ```toml > d1 = [ > "superset-engine-d1>=0.26.3", > "sqlalchemy-d1>=0.1.0", > "dbapi-d1>=0.1.0", > ] > ``` > > This way to use d1 people can do: > > ```shell > pip install "superset[d1]" > ``` > > And have all dependencies installed. Thanks for the suggestion @betodealmeida We've added the d1 optional dependency group to pyproject.toml with the three packages included. > Let's also add the package as an optional dependency here: > > https://github.com/apache/superset/blob/a18b62cf6b82c0ba73902941d5c4f807baa25016/pyproject.toml#L114 > > Something like: > > ```toml > d1 = [ > "superset-engine-d1>=0.26.3", > "sqlalchemy-d1>=0.1.0", > "dbapi-d1>=0.1.0", > ] > ``` > > This way to use d1 people can do: > > ```shell > pip install "superset[d1]" > ``` > > And have all dependencies installed. Thanks for the suggestion @betodealmeida! We've added the d1 optional dependency group to `pyproject.toml` with the three packages included, and also added the alternate pip command to the database documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
