codeant-ai-for-open-source[bot] commented on PR #34490: URL: https://github.com/apache/superset/pull/34490#issuecomment-3638812523
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/34490/files#diff-92c1e37f063c3f359ffc16d1d51cefecd36e59164e41d5fb3367ebc21923088dR100-R116'><strong>Navigation blocking simulation</strong></a><br>Tests simulate blocked navigation using `history.block((tx: any) => tx); unblock(); history.push(...)`. Calling `unblock()` immediately before `push()` likely cancels the block, making the test rely on implementation details. Verify the intent: either keep the blocker active during `push()` or explicitly simulate a blocked navigation in a clearer way (e.g., keep the block active, return false, or capture the tx and invoke navigation confirmation logic).<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
