andre-fong commented on PR #36344: URL: https://github.com/apache/superset/pull/36344#issuecomment-3640013541
Thanks for the awesome detailed review and taking the time to test this out! We're glad to hear you find value in the POC and that it's working well on your end 😄 > I could imagine an alternate version of controls to power the charts. The interpretation I think might get a lot of use is to have each chart column use TWO inputs... a dimension and a metric (i.e. x axis and y axis). Indeed, we thought about this interpretation as well! On top of our simpler method of plotting only the row's data in each chart, we could have each chart column have a dimension and a metric so that it displays its own data that does not necessarily have to be pre-populated in the table. We determined this interpretation to be out of scope for our POC due to its complexity, but we agree that this would leverage the strength of having a chart visualization inside of a table more! Something like [the Finance demo table example](https://www.ag-grid.com/example-finance/) from AG Grid's demo tables would be ideal. > If you want to keep chipping at this, we can talk about some next moves. If you want to call it done, maybe we can target a feature branch instead of master — I can make one, and you can re-target the PR, then I (or others, including y'all) could keep chipping away at it :D I think this would be the best approach going forward. As our contribution to this project is wrapping up, this allows us to get the POC merged while leaving the door open for others to implement those future enhancements. I'm happy to re-target the PR once the feature branch is created, just let me know. Thanks Evan! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
