codeant-ai-for-open-source[bot] commented on PR #36479: URL: https://github.com/apache/superset/pull/36479#issuecomment-3641241668
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36479/files#diff-ec7ae20fec66c73862729b95fee0e03ed1d33b3e7c5ae752b32e71a62685819bR472-R522'><strong>Conditional CSS logic</strong></a><br>Several StyledInputContainer usages changed their conditional css expressions (inverted conditions). Verify the intended spacing rules across combinations of `isFileUploadSupportedByEngine` and `db?.allow_file_upload`. Confirm these conditions do not unintentionally collapse margins or leave empty style objects being passed to the `css` prop.<br> - [ ] <a href='https://github.com/apache/superset/pull/36479/files#diff-ec7ae20fec66c73862729b95fee0e03ed1d33b3e7c5ae752b32e71a62685819bR535-R536'><strong>New className added</strong></a><br>A new `className="extra-container"` was added for the schemas upload block to avoid collapsed spacing. Ensure the CSS for `extra-container` exists in the corresponding styles (or prefer a styled-prop). If the class is missing this will have no effect.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
