alexandrusoare commented on PR #36528: URL: https://github.com/apache/superset/pull/36528#issuecomment-3645683508
> Approving it and I know we generally don't test css changes but this is a behaviour fix and we can probably write a test for this right? The complexity for this is quite high because the issue this fixing is for the scenario where you are in editmode and you have a tab within a column. You can't easily mock this because the components are deeply nested in this context. What we can do is add a css test to check if the property is right, but it doesn't help much. Let me know your thoughts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
