bito-code-review[bot] commented on code in PR #36603:
URL: https://github.com/apache/superset/pull/36603#discussion_r2616982240
##########
superset/db_engine_specs/hive.py:
##########
@@ -272,8 +272,6 @@ def adjust_engine_params(
catalog: str | None = None,
schema: str | None = None,
) -> tuple[URL, dict[str, Any]]:
- if schema:
- uri = uri.set(database=parse.quote(schema, safe=""))
return uri, connect_args
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Broken Schema Support</b></div>
<div id="fix">
Removing schema handling breaks dynamic schema support for Hive, as
`supports_dynamic_schema=True` but no implementation exists. Restore the `if
schema:` block to fix this regression.
</div>
</div>
<small><i>Code Review Run #c0a548</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
