nitishagar opened a new pull request, #36606:
URL: https://github.com/apache/superset/pull/36606

   ### SUMMARY
   
     Update Pivot Table chart to display "Subvalue (Sum)", "Subvalue 
(Average)", etc. instead of just "Subtotal" for sub-group aggregations.
   
     This provides consistency with how "Total" labels already display the 
aggregation function name (e.g., "Total (Sum)").
   
     **Changes:**
     - `TableRenderers.jsx:493` - Column subtotal label now includes 
aggregation function
     - `TableRenderers.jsx:708` - Row subtotal label now includes aggregation 
function
   
     Both changes follow the existing pattern used for "Total" labels at lines 
518-520.
   
     ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
     **Before:** Subtotal labels show just "Subtotal"
     **After:** Subtotal labels show "Subvalue (Sum)", "Subvalue (Average)", 
etc.
   
     ### TESTING INSTRUCTIONS
   
     1. Create a Pivot Table chart
     2. Add columns and rows to the configuration
     3. Enable "Show rows subtotal" and "Show columns subtotal"
     4. Verify subtotal labels now display "Subvalue (Sum)" or appropriate 
aggregation
     5. Change aggregation function and verify label updates accordingly
     6. Compare with "Total" labels - format should be consistent
   
     ### ADDITIONAL INFORMATION
   
     - [x] Has associated issue: Fixes #35089
     - [ ] Required feature flags:
     - [x] Changes UI
     - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
       - [ ] Migration is atomic, supports rollback & is backwards-compatible
       - [ ] Confirm DB migration upgrade and downgrade tested
       - [ ] Runtime estimates and downtime expectations provided
     - [ ] Introduces new feature or API
     - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to