LevisNgigi opened a new pull request, #36639:
URL: https://github.com/apache/superset/pull/36639

   <!---
   fix: fix error with dashboard filters when global async queries is enabled 
and user navigates quickly
   -->
   
   ### SUMMARY
   Prevents aborted chart requests from surfacing as hard errors in the UI.
   Treats AbortError / "Request aborted" responses as expected behavior (e.g. 
when filters change quickly or charts unmount) and dispatches 
chartUpdateStopped(key) instead of chartUpdateFailed.
   Keeps real failures unchanged: for non-abort errors, especially when 
GlobalAsyncQueries is enabled, the raw error still flows through 
chartUpdateFailed, preserving existing error handling.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE:
   
   
https://github.com/user-attachments/assets/c489e3af-0d2f-44b1-8c20-dac414d86f1c
   
   AFTER:
   
   
https://github.com/user-attachments/assets/8c4e1fc9-23e3-42ed-ab54-23449b8cebce
   
   ### TESTING INSTRUCTIONS
   Make sure global async queries is enabled first:
   On a dashboard, add cross filters
   Quickly change them to other filters
   OR
   On a dashboard, apply filters, then quickly use the browser forward button 
then back
   Currently:
   Signal aborted error does not appear. User does not  see an error and the 
dashboards with filters should load properly
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to