codeant-ai-for-open-source[bot] commented on PR #36529: URL: https://github.com/apache/superset/pull/36529#issuecomment-3655858230
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36529/files#diff-5cd37c5eb2726beb8fd5f49f36a9516170e5a8402e6d5236fa40bf8fc5be40faR86-R115'><strong>Double patching</strong></a><br>Several tests (e.g. the "with options" test) patch `database.get_raw_connection` after calling the helper `mock_query_execution` which itself already patches `get_raw_connection`. This double-patching can make assertions fragile or misleading because the "wraps" call may be wrapping an already mocked object. Prefer patching once or asserting on the mock returned by the helper.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
