rusackas commented on PR #36498: URL: https://github.com/apache/superset/pull/36498#issuecomment-3658102126
## PR Review Feedback Addressed Rebased on master and addressed the following review feedback: ### 1. Script Comment Mismatch ✅ Fixed misleading header comment that claimed the script scans for `extension-compatible` tags. The comment now accurately states it processes all stories in `superset-core/src`. ### 2. Hardcoded "Sample alert message" ✅ The MDX generator is now **story-driven** - it extracts actual `args` and `controls` from Storybook stories instead of generating hardcoded Alert-specific code. This means: - Props like `message` and `description` are pulled from `InteractiveX.args` - Text controls are automatically added for string props - Prop descriptions come from `argTypes` metadata - The generated code works for any component, not just Alert ### 3. Alert-like Component Structure Assumption ✅ Fixed - same as above. Live examples now use actual story props. ### 4. Webpack/TypeScript Alias Mismatch ✅ Added clarifying comments to both `webpack.extend.ts` and `tsconfig.json` explaining the intentional split: - Webpack resolves actual component source for runtime - TypeScript uses simplified generated types for IDE support ### 5. Inconsistent Import Path ✅ Updated all imports from `@apache-superset/core` to `@apache-superset/core/ui` to match the established pattern used throughout the Superset codebase. ### 6. Components Section Sidebar Position ✅ Moved Components from the end of the Extensions sidebar to after "Contribution Types" - following the logical learning path: understand the toolkit → learn extension points → build. --- All changes are purely programmatic (regex parsing + string templates) with no AI involved in the doc generation itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
