sadpandajoe commented on issue #36595: URL: https://github.com/apache/superset/issues/36595#issuecomment-3659094884
Just confirmed that this may be related to this [PR](https://github.com/apache/superset/pull/36281). The bug is caused by a useEffect in [TableChart.tsx](https://github.com/apache/superset/blob/master/superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx#L1375-L1400 ) (lines 1375-1400) that has serverPaginationData in its dependency array while also calling updateTableOwnState which UPDATES serverPaginationData. The Loop: 1. Component renders → clientViewRows or exportColumns changes 2. useEffect runs → calls updateTableOwnState(setDataMask, {...serverPaginationData, clientView: ...}) 3. This updates serverPaginationData via setDataMask → triggers parent re-render 4. Parent re-renders with new serverPaginationData → triggers child re-render 5. useEffect runs again because serverPaginationData changed 6. Even though prevClientViewRef is set, the object identity of serverPaginationData differs 7. Loop continues I don't think this is part of 6.0 so removing it from the board. I can probably still put up a fix, but it won't be as urgent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
