codeant-ai-for-open-source[bot] commented on PR #36671: URL: https://github.com/apache/superset/pull/36671#issuecomment-3659952192
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36671/files#diff-19e7846069d6c476997feb4666056a94714a7a42c341661fc79c086196142f29R200-R226'><strong>Missing useCallback dependencies</strong></a><br>The `menuItems` function is wrapped with `useCallback` but the callback's dependency array is empty. The callback references external variables (e.g., `canEdit`, `canDelete`, `addDangerToast`, `addSuccessToast`, `copyQueryLink`, and `theme`) and can therefore capture stale values leading to incorrect menu contents or wrong behavior after props/state change.<br> - [ ] <a href='https://github.com/apache/superset/pull/36671/files#diff-19e7846069d6c476997feb4666056a94714a7a42c341661fc79c086196142f29R340-R354'><strong>Visual/spacing regression risk</strong></a><br>The `QueryData` wrapper that previously applied spacing/margin for the action icons was removed. The new implementation uses `Icons.MoreOutlined` with only `iconSize="xl"`. This may cause spacing/alignment differences compared with other card types (previous behavior relied on wrapper CSS). Verify the menu button margin/padding and icon vertical alignment across all card types to ensure consistent UX.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
