Vitor-Avila opened a new pull request, #36680: URL: https://github.com/apache/superset/pull/36680
### SUMMARY This is a follow up to https://github.com/apache/superset/pull/24703. During the viz type migration, we were storing the `form_data` as a string, which would then cause issues when loading a dashboard. This PR fixes the issue for new viz type migrations, and also has a DB migration for existing charts in this state. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before** https://github.com/user-attachments/assets/d11ef404-096e-46c3-84da-22a2f40302dc **After https://github.com/user-attachments/assets/c6cd0ae0-d185-476b-b6ff-4ddaafce85dc ### TESTING INSTRUCTIONS Unit test added. For manual testing: 1. Create a legacy chart. 2. Add it to a dashboard. 3. Export the chart. 4. Import it. 5. Access the dashboard, and confirm you don't get any errors. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
