pipina commented on issue #36682:
URL: https://github.com/apache/superset/issues/36682#issuecomment-3664966534
Hi Dosu,
works like a magic!
thanks
ab
On Tue, 2025-12-16 at 12:58 -0800, dosubot[bot] wrote:
> dosubot[bot] left a comment (apache/superset#36682) [1]
> Hi @pipina [2]! I'm Dosu [3] and I’m helping the superset team.
> The root cause is that the email report workflow re-parses CSV data
> using pandas with the default comma delimiter, ignoring your custom
> CSV_EXPORT settings. This causes a parsing error when your CSV uses a
> non-default delimiter like ;, resulting in HTTP 500 errors for email
> reports, while GUI exports work fine.
> To fix this, update the apply_client_processing function in
> superset/charts/client_processing.py so it respects your delimiter
> and decimal settings. Here’s how you can do it:
> 1.
> Import current_app from Flask at the top of the file:from flask
> import current_app
> 2.
> In the CSV parsing block, retrieve the delimiter and decimal from
> config and pass them to pd.read_csv:csv_export_config =
> current_app.config.get("CSV_EXPORT", {})
> sep = csv_export_config.get("sep", ",")
> decimal = csv_export_config.get("decimal", ".")
> df = pd.read_csv(StringIO(data), sep=sep, decimal=decimal)
> This change ensures that CSV parsing in email reports matches your
> GUI export settings and prevents the parsing error. The rest of the
> workflow (including encoding) already pulls from CSV_EXPORT where
> needed.
> There’s no official documentation or open issue tracking this bug,
> but the code pattern above matches how Superset handles CSV_EXPORT
> elsewhere in the codebase. GUI exports are unaffected; only
> email/report CSV exports with non-default delimiters are broken until
> this is fixed.
> Reference: superset/charts/client_processing.py [4]
> To reply, just mention @dosu [3].
> How did I do? Good [5] | Irrelevant [6] | Incorrect [7] | Verbose [8]
> | Hallucination [9] | Report 🐛 [10] | Other [11]
>
> —
> Reply to this email directly, view it on GitHub [1], or unsubscribe
> [12].
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
[1] (apache/superset#36682)
https://github.com/apache/superset/issues/36682#issuecomment-3662355695
[2] @pipina https://github.com/pipina
[3] Dosu https://go.dosu.dev/dosubot
[4] superset/charts/client_processing.py
https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/charts/client_processing.py#L311-L387
[5] Good
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=great_response
[6] Irrelevant
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=irrelevant_answer
[7] Incorrect
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=incorrect_sources
[8] Verbose
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=too_verbose
[9] Hallucination
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=hallucination
[10] Report 🐛
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=bug_report
[11] Other
https://app.dosu.dev/response-feedback/235f157d-6ad0-4f7b-8281-622e1ce2d8a2?feedback_type=other
[12] unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQWXGXGADFNMLSKLX4PCBT4CBW7VAVCNFSM6AAAAACPHTCBIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNRSGM2TKNRZGU
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
