rusackas opened a new pull request, #36721:
URL: https://github.com/apache/superset/pull/36721
## Summary
Migrate utility files from JavaScript to TypeScript with proper type
annotations. This continues the ongoing effort to eliminate `any` types and
improve type safety across the frontend codebase.
### Files migrated (JS → TS):
- `mockMessageToasts.js` → `.ts` - Add `Partial<ToastMeta>[]` type
- `handleHover.js` → `.ts` - Add `DragDropComponent` interface with proper
typing for react-dnd
- `getFilterFieldNodesTree.js` → `.ts` - Add `DashboardFilter`,
`FilterFieldNode` interfaces
- `getSelectedChartIdForFilterScopeTree.js` → `.ts` - Add params interface
- `updateComponentParentsList.js` → `.ts` - Add `LayoutComponent` interface
- `findNonTabChildChartIds.js` → `.ts` - Use `Layout` and `LayoutItem` types
from `dashboard/types`
- `findTopLevelComponentIds.js` → `.ts` - Use proper types, add
`TopLevelNode` interface
- `getLoadStatsPerTopLevelComponent.js` → `.ts` - Use proper `Layout` and
`ChartState` types
- `saveModalReducer.js` → `.ts` - Add `SaveModalState` and `SaveModalAction`
interfaces
### Additional changes:
- `handleScroll/index.ts`: Update parameter type to accept `string | null`
(fixes type mismatch with `handleHover.ts`)
- Remove duplicate JS files that already have TS counterparts:
- `getControlsForVizType.js` (duplicate of `.ts`)
- `reducerUtils.js` (duplicate of `.ts`)
## Test plan
- [x] Pre-commit hooks pass (prettier, eslint, TypeScript type-checking)
- [x] No runtime changes - purely type annotation additions
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
