codeant-ai-for-open-source[bot] commented on PR #36723: URL: https://github.com/apache/superset/pull/36723#issuecomment-3668645051
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36723/files#diff-2a026a8f4952fb573dedd7ed4fb012e9c91361a2520a40a5cd2a0a4510c7ab8bR108-R137'><strong>Weak onChange Assertions</strong></a><br>The tests assert that `onChange` was called but don't assert how many times it was called. If the component triggers multiple calls (e.g., intermediate state updates), the test will still pass and could mask regressions. Consider asserting the expected call count and verifying the exact call arguments shape.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
