villebro commented on code in PR #36739:
URL: https://github.com/apache/superset/pull/36739#discussion_r2632438362
##########
superset/mcp_service/sql_lab/tool/execute_sql.py:
##########
@@ -18,32 +18,39 @@
"""
Execute SQL MCP Tool
-Tool for executing SQL queries against databases with security validation
-and timeout protection.
+Tool for executing SQL queries against databases using the unified
+Database.execute() API with RLS, template rendering, and security validation.
"""
+from __future__ import annotations
+
import logging
+from typing import Any, TYPE_CHECKING
from fastmcp import Context
+from superset_core.api.types import CacheOptions, QueryOptions, QueryResult,
QueryStatus
from superset_core.mcp import tool
-from superset.mcp_service.sql_lab.execute_sql_core import ExecuteSqlCore
+from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
+from superset.exceptions import SupersetErrorException,
SupersetSecurityException
from superset.mcp_service.sql_lab.schemas import (
+ ColumnInfo,
ExecuteSqlRequest,
ExecuteSqlResponse,
+ StatementInfo,
)
from superset.mcp_service.utils.schema_utils import parse_request
+if TYPE_CHECKING:
+ pass
+
Review Comment:
```suggestion
```
##########
superset/mcp_service/sql_lab/tool/execute_sql.py:
##########
@@ -18,32 +18,39 @@
"""
Execute SQL MCP Tool
-Tool for executing SQL queries against databases with security validation
-and timeout protection.
+Tool for executing SQL queries against databases using the unified
+Database.execute() API with RLS, template rendering, and security validation.
"""
+from __future__ import annotations
+
import logging
+from typing import Any, TYPE_CHECKING
Review Comment:
```suggestion
from typing import Any
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
