codeant-ai-for-open-source[bot] commented on PR #36764: URL: https://github.com/apache/superset/pull/36764#issuecomment-3674305053
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36764/files#diff-d99f0f2e7e0e8b8fd1cee2c49f5ded968c8fb11689dbdf70674315155d901a30R193-R197'><strong>Permission / Consumer handling</strong></a><br>Adding a new action usually requires updates where action strings are checked (e.g., permission lists, audit logs, backend endpoints). Verify all code paths that switch on or whitelist Actions values (UI menus, role/permission checks, API handlers) are updated to handle this new value and that tests cover it.<br> - [ ] <a href='https://github.com/apache/superset/pull/36764/files#diff-c3def2a59df5a4136beb3454bd0be8faa38e66e74395223494897fce54500744R212-R220'><strong>Field name mismatch</strong></a><br>The FormItem uses `name="active"` but the Checkbox onChange sets `isActive` via `form.setFieldsValue({ isActive: checked })`. This inconsistency will prevent the `active` value from being saved/submitted and can cause UI and API mismatch. Verify the form field name matches the app/api contract (either `active`, `isActive`, or `is_active`) and use the same key everywhere.<br> - [ ] <a href='https://github.com/apache/superset/pull/36764/files#diff-4dd9b15038529edf3c0bda24126816e429f52c3b69d5b5dd249f84f8ea519c3dR37-R42'><strong>Modal component export / props</strong></a><br>The new import adds `UserListPasswordChangeModal` from 'src/features/users/UserListModal' and the modal is passed `roles` and `groups`. Verify that the component is exported from that module and accepts these props; otherwise this will cause a runtime or compile failure.<br> - [ ] <a href='https://github.com/apache/superset/pull/36764/files#diff-d99f0f2e7e0e8b8fd1cee2c49f5ded968c8fb11689dbdf70674315155d901a30R193-R197'><strong>Naming consistency</strong></a><br>The new enum value uses snake_case ('password_change') while the other action values are single-word lowercase strings ('create', 'update'). Confirm the string format (snake_case vs camelCase vs single-word) is intentionally chosen and is supported by all consumers (UI, backend, permission checks). Inconsistent formats can cause runtime mismatches when values are compared.<br> - [ ] <a href='https://github.com/apache/superset/pull/36764/files#diff-4dd9b15038529edf3c0bda24126816e429f52c3b69d5b5dd249f84f8ea519c3dR362-R368'><strong>Unknown icon usage</strong></a><br>The new action uses icon: 'KeyOutlined' as a string (consistent with other actions), but it's important to confirm that this icon key actually exists where ActionsBar resolves icons. If it doesn't, the icon will not render. Consider using the Icons component (e.g., Icons.KeyOutlined) or validate the string mapping.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
