codeant-ai-for-open-source[bot] commented on PR #36784: URL: https://github.com/apache/superset/pull/36784#issuecomment-3680681155
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36784/files#diff-ecf53b9bdd6afc93272e2b576cc8fd95671126e3441ef8b077e208b2dc372da0R214-R216'><strong>Units mismatch / Incomplete disable</strong></a><br>The PR uses `lineWidthMinPixels` to conditionally apply line width when `stroked` is true. `lineWidthMinPixels` affects pixel-based rendering helpers, but the effective polygon outline width is normally controlled by `getLineWidth` together with `lineWidthUnits` (which can be 'pixels' or 'meters'). If `lineWidthUnits` is not pixels, or in some deck.gl versions, setting `lineWidthMinPixels` alone may not prevent outlines from being rendered when `stroked` is false. This could re-introduce the original issue in some configurations. Verify across unit settings and deck.gl versions that outlines are fully suppressed when `stroked` is false.<br> - [ ] <a href='https://github.com/apache/superset/pull/36784/files#diff-ecf53b9bdd6afc93272e2b576cc8fd95671126e3441ef8b077e208b2dc372da0R215-R215'><strong>Value robustness</strong></a><br>The code uses `fd.line_width` directly. If `line_width` can be non-numeric (e.g., string from form data) or negative, unexpected rendering may occur. Ensure the value is coerced to a non-negative number and clamped if necessary before being passed to deck.gl props.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
