codeant-ai-for-open-source[bot] commented on code in PR #36792:
URL: https://github.com/apache/superset/pull/36792#discussion_r2639596932
##########
superset/commands/database/uploaders/base.py:
##########
@@ -159,6 +159,13 @@ def run(self) -> None:
if not self._model:
return
+ # Treat empty or frontend-sent "undefined" schema as no schema
+ if not self._schema or self._schema == "undefined":
Review Comment:
**Suggestion:** Edge case: the current check `if not self._schema or
self._schema == "undefined":` does not treat whitespace-only schema values or
case variations (e.g., `" "`, `"Undefined"`) as empty/undefined and may pass
an invalid schema through; trim and do a case-insensitive check before deciding
to treat it as absent. [possible bug]
**Severity Level:** Critical 🚨
```suggestion
if self._schema is None or (
isinstance(self._schema, str)
and (self._schema.strip() == "" or self._schema.strip().lower()
== "undefined")
):
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a practical hardening: the current check misses whitespace-only
strings and case variants like "Undefined". Using .strip() and a
case-insensitive comparison avoids passing invalid values through as real
schema names. It fixes a real edge case that can cause confusing validation or
DB lookups.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/database/uploaders/base.py
**Line:** 163:163
**Comment:**
*Possible Bug: Edge case: the current check `if not self._schema or
self._schema == "undefined":` does not treat whitespace-only schema values or
case variations (e.g., `" "`, `"Undefined"`) as empty/undefined and may pass
an invalid schema through; trim and do a case-insensitive check before deciding
to treat it as absent.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
