bito-code-review[bot] commented on code in PR #36793:
URL: https://github.com/apache/superset/pull/36793#discussion_r2639630013
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/Polygon.tsx:
##########
@@ -212,7 +212,7 @@ export const getLayer: GetLayerType<PolygonLayer> =
function ({
getPolygon: getPointsFromPolygon,
getFillColor: colorScaler,
getLineColor: sc ? [sc.r, sc.g, sc.b, 255 * sc.a] : undefined,
- getLineWidth: fd.line_width,
+ lineWidthMinPixels: fd.stroked ? fd.line_width : 0,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect deck.gl property usage</b></div>
<div id="fix">
Replacing `getLineWidth` with `lineWidthMinPixels` changes polygon outline
behavior from setting the actual width to only enforcing a minimum pixel width.
This can result in thinner lines than expected, especially when `fd.line_width`
differs from the default. Other deck.gl layers in the codebase still use
`getLineWidth`, and deck.gl docs confirm both properties exist but serve
different purposes.
</div>
</div>
<small><i>Code Review Run #dc0c85</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
