codeant-ai-for-open-source[bot] commented on code in PR #35751:
URL: https://github.com/apache/superset/pull/35751#discussion_r2642731443
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -504,7 +504,7 @@ const Select = forwardRef(
handleSelectAll();
}}
>
- {`${t('Select all')} (${bulkSelectCounts.selectable})`}
+ {t('Select all')} {`(${bulkSelectCounts.selectable})`}
Review Comment:
**Suggestion:** Internationalization bug: the button text is built by
concatenating a translated string and a separately rendered count, which
prevents translators from reordering words or handling pluralization/grammar in
other languages (e.g., Russian). Replace the concatenation with a single
translation call that accepts the count as an argument so translators can
provide a correct localized sentence or plural form. [logic error]
**Severity Level:** Minor ⚠️
```suggestion
{t('Select all (%s)', bulkSelectCounts.selectable)}
```
<details>
<summary><b>Why it matters? ⭐ </b></summary>
This is a legitimate i18n concern — concatenating a translated string and a
raw count forces a specific word order and prevents translators from handling
grammar/plurals properly. Replacing with a single translation call that accepts
the count (or a proper pluralization key) fixes that. The code in the PR
contains exactly the concatenation, so the suggestion is applicable and
improves localization correctness.
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
**Line:** 507:507
**Comment:**
*Logic Error: Internationalization bug: the button text is built by
concatenating a translated string and a separately rendered count, which
prevents translators from reordering words or handling pluralization/grammar in
other languages (e.g., Russian). Replace the concatenation with a single
translation call that accepts the count as an argument so translators can
provide a correct localized sentence or plural form.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
