bito-code-review[bot] commented on code in PR #36821: URL: https://github.com/apache/superset/pull/36821#discussion_r2644910793
########## docker/Dockerfile.hive: ########## @@ -0,0 +1,16 @@ +FROM apache/superset:latest + +USER root + +# Install system dependencies for thrift-sasl +RUN apt-get update -q \ + && apt-get install -yq --no-install-recommends \ + libsasl2-dev \ + build-essential \ + libpq-dev \ + && rm -rf /var/lib/apt/lists/* + +# Install python dependencies inside the virtual environment using uv +RUN uv pip install --system --python /app/.venv pyhive thrift thrift-sasl psycopg2-binary Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect UV Install</b></div> <div id="fix"> The --system flag installs packages globally, not in the venv. Remove it to match main Dockerfile patterns. </div> </div> <small><i>Code Review Run #c576fd</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
