dosubot[bot] commented on issue #36878:
URL: https://github.com/apache/superset/issues/36878#issuecomment-3701955437

   <!-- Greeting -->
   Hi @Yashh-p! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the 
superset team.
   
   <!-- Answer -->
   Here's what Superset 6.0.0 supports for theming and chart overrides:
   
   **Ant Design theme tokens** only affect core UI elements—navigation, menus, 
buttons, modals, and some table controls. Tokens like `fontFamily`, 
`fontSizeHeading1-5`, `lineHeightHeading1-5`, and color tokens are supported, 
but they do not impact dashboard content, chart titles, or chart visuals. 
Dashboard and chart card appearance are not styled by Ant Design tokens; for 
those, you need to use the CSS module or custom CSS 
[[docs](https://github.com/apache/superset/issues/36794)].
   
   **Authoritative list of UI elements consuming Ant Design tokens:**  
   - Navigation bar  
   - Menus  
   - Buttons  
   - Modals  
   - Table controls  
   - Some filter controls  
   Elements like dashboard titles, chart titles, and dashboard content are not 
affected [[source](https://github.com/apache/superset/issues/36794)].
   
   **ECharts options overrides:**  
   - `echartsOptionsOverrides` (global) and 
`echartsOptionsOverridesByChartType` (per chart type) apply only to 
ECharts-based visualizations.
   - These overrides affect all charts of a given type, not individual chart 
instances.
   - Supported chart types for per-type overrides (as of 6.0.0): BigNumber with 
trendline, BoxPlot, Gantt, Graph, Heatmap, Histogram, MixedTimeseries, Sankey, 
Sunburst, Tree, Treemap, Waterfall.  
   - Example: setting `backgroundColor` for `box_plot` in 
`echartsOptionsOverridesByChartType` will apply to all BoxPlot charts [[PR 
#36389](https://github.com/apache/superset/pull/36389)].
   - There is no built-in way to target a specific chart instance; for that, 
you would need custom code or a chart plugin 
[[discussion](https://github.com/apache/superset/discussions/36851)].
   
   **Tokens intentionally ignored:**  
   - Any property not in the allowed Ant Design token list (e.g., custom 
`chartColors`) is ignored by the theme system 
[[source](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/theme/types.ts)].
   - ECharts overrides in the theme JSON are not processed by the UI theme 
system for non-ECharts charts.
   
   **UI-only vs chart-only tokens:**  
   - Ant Design tokens are UI-only.
   - ECharts overrides are chart-only and only for supported ECharts chart 
types.
   
   **Configuration requirements:**  
   - For live theme editing, enable the `THEME_ALLOW_THEME_EDITOR_BETA` feature 
flag.
   - For instance-wide changes, update `superset_config.py` and restart 
Superset.
   - No cache busting is required for font URLs; fonts load at runtime via CSS 
`@import` if from allowed domains [[PR 
#36317](https://github.com/apache/superset/pull/36317)].
   - Enhanced theme validation and error handling are available via the 
`ENHANCED_THEME_VALIDATION` feature flag [[PR 
#35349](https://github.com/apache/superset/pull/35349)].
   
   **Limitations:**  
   - No visible changes to dashboard or chart visuals from Ant Design tokens.
   - ECharts overrides cannot be applied per chart instance.
   - For advanced chart theming, use dashboard CSS or custom chart plugins.
   
   If you need a full mapping of allowed Ant Design tokens, see the [source 
code](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/theme/types.ts).
 For ECharts options, refer to the [chart plugin 
code](https://github.com/apache/superset/pull/36389) and ECharts documentation 
for supported option keys.
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/ff0b129f-6bfa-44ef-bec2-a23b3b3cd305?feedback_type=other)</sup>
   
   [![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=Here%27s%20what%20Superset%206.0.0%20supports%20for%20theming%20and%20chart%20overrides%3A%0A%0A%2A%2AAnt%20Design%20theme%20tokens%2A%2A%20only%20affect%20core%20UI%20elements%E2%80%94navigation%2C%20menus%2C%20buttons%2C%20modals%2C%20and%20some%20table%20controls.%20Tokens%20like%20%60fontFamily%60%2C%20%60fontSizeHeading1-5%60%2C%20%60lineHeightHeading1-5%60%2C%20and%20color%20tokens%20are%20supported%2C%20but%20they%20do%20not%20impact%20dashboard%20content%2C%20chart%20titles%2C%20or%20chart%20visuals.%20Dashboard%20and%20chart%20card%20appearance%20are%20not%20styled%20by%20Ant%20Design%20tokens%3B%20for%20those%2C%20you%20need%20to%20use%20the%20CSS%20module%20or%20custom%20CSS%20%5B%5Bdocs%5D%28https%3A//github.com/apache/superset/issues/3
 
6794%29%5D.%0A%0A%2A%2AAuthoritative%20list%20of%20UI%20elements%20consuming%20Ant%20Design%20tokens%3A%2A%2A%20%20%0A-%20Navigation%20bar%20%20%0A-%20Menus%20%20%0A-%20Buttons%20%20%0A-%20Modals%20%20%0A-%20Table%20controls%20%20%0A-%20Some%20filter%20controls%20%20%0AElements%20like%20dashboard%20titles%2C%20chart%20titles%2C%20and%20dashboard%20content%20are%20not%20affected%20%5B%5Bsource%5D%28https%3A//github.com/apache/superset/issues/36794%29%5D.%0A%0A%2A%2AECharts%20options%20overrides%3A%2A%2A%20%20%0A-%20%60echartsOptionsOverrides%60%20%28global%29%20and%20%60echartsOptionsOverridesByChartType%60%20%28per%20chart%20type%29%20apply%20only%20to%20ECharts-based%20visualizations.%0A-%20These%20overrides%20affect%20all%20charts%20of%20a%20given%20type%2C%20not%20individual%20chart%20instances.%0A-%20Supported%20chart%20types%20for%20per-type%20overrides%20%28as%20of%206.0.0%29%3A%20BigNumber%20with%20trendline%2C%20BoxPlot%2C%20Gantt%2C%20Graph%2C%20Heatmap%2C%20Histogram%2C%20
 
MixedTimeseries%2C%20Sankey%2C%20Sunburst%2C%20Tree%2C%20Treemap%2C%20Waterfall.%20%20%0A-%20Example%3A%20setting%20%60backgroundColor%60%20for%20%60box_plot%60%20in%20%60echartsOptionsOverridesByChartType%60%20will%20apply%20to%20all%20BoxPlot%20charts%20%5B%5BPR%20%2336389%5D%28https%3A//github.com/apache/superset/pull/36389%29%5D.%0A-%20There%20is%20no%20built-in%20way%20to%20target%20a%20specific%20chart%20instance%3B%20for%20that%2C%20you%20would%20need%20custom%20code%20or%20a%20chart%20plugin%20%5B%5Bdiscussion%5D%28https%3A//github.com/apache/superset/discussions/36851%29%5D.%0A%0A%2A%2ATokens%20intentionally%20ignored%3A%2A%2A%20%20%0A-%20Any%20property%20not%20in%20the%20allowed%20Ant%20Design%20token%20list%20%28e.g.%2C%20custom%20%60chartColors%60%29%20is%20ignored%20by%20the%20theme%20system%20%5B%5Bsource%5D%28https%3A//github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/theme/types.ts%29%5D.%0A-%20ECharts%20overrides%20in%20the%20the
 
me%20JSON%20are%20not%20processed%20by%20the%20UI%20theme%20system%20for%20non-ECharts%20charts.%0A%0A%2A%2AUI-only%20vs%20chart-only%20tokens%3A%2A%2A%20%20%0A-%20Ant%20Design%20tokens%20are%20UI-only.%0A-%20ECharts%20overrides%20are%20chart-only%20and%20only%20for%20supported%20ECharts%20chart%20types.%0A%0A%2A%2AConfiguration%20requirements%3A%2A%2A%20%20%0A-%20For%20live%20theme%20editing%2C%20enable%20the%20%60THEME_ALLOW_THEME_EDITOR_BETA%60%20feature%20flag.%0A-%20For%20instance-wide%20changes%2C%20update%20%60superset_config.py%60%20and%20restart%20Superset.%0A-%20No%20cache%20busting%20is%20required%20for%20font%20URLs%3B%20fonts%20load%20at%20runtime%20via%20CSS%20%60%40import%60%20if%20from%20allowed%20domains%20%5B%5BPR%20%2336317%5D%28https%3A//github.com/apache/superset/pull/36317%29%5D.%0A-%20Enhanced%20theme%20validation%20and%20error%20handling%20are%20available%20via%20the%20%60ENHANCED_THEME_VALIDATION%60%20feature%20flag%20%5B%5BPR%20%2335349%5D%28https%3A//githu
 
b.com/apache/superset/pull/35349%29%5D.%0A%0A%2A%2ALimitations%3A%2A%2A%20%20%0A-%20No%20visible%20changes%20to%20dashboard%20or%20chart%20visuals%20from%20Ant%20Design%20tokens.%0A-%20ECharts%20overrides%20cannot%20be%20applied%20per%20chart%20instance.%0A-%20For%20advanced%20chart%20theming%2C%20use%20dashboard%20CSS%20or%20custom%20chart%20plugins.%0A%0AIf%20you%20need%20a%20full%20mapping%20of%20allowed%20Ant%20Design%20tokens%2C%20see%20the%20%5Bsource%20code%5D%28https%3A//github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/src/theme/types.ts%29.%20For%20ECharts%20options%2C%20refer%20to%20the%20%5Bchart%20plugin%20code%5D%28https%3A//github.com/apache/superset/pull/36389%29%20and%20ECharts%20documentation%20for%20supported%20option%20keys.)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on X](https://img.shields.io/badge/X-share-black)](https://t
 
witter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/36878)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to