bito-code-review[bot] commented on code in PR #36644:
URL: https://github.com/apache/superset/pull/36644#discussion_r2655902740
##########
superset-frontend/src/SqlLab/components/TabbedSqlEditors/index.tsx:
##########
@@ -41,6 +41,40 @@ const StyledEditableTabs = styled(EditableTabs)`
height: 100%;
display: flex;
flex-direction: column;
+ & .ant-tabs-nav::before {
+ border-color: ${({ theme }) => theme.colorBorder} !important;
+ }
+ & .ant-tabs-nav-add {
+ border-color: ${({ theme }) => theme.colorBorder} !important;
+ height: 34px;
+ }
+ & .ant-tabs-nav-list {
+ align-items: end;
+ padding-top: 1px;
+ column-gap: ${({ theme }) => theme.sizeUnit}px;
+ }
+ & .ant-tabs-tab-active {
+ border-left-color: ${({ theme }) => theme.colorPrimaryActive} !important;
+ border-top-color: ${({ theme }) => theme.colorPrimaryActive} !important;
+ border-right-color: ${({ theme }) => theme.colorPrimaryActive} !important;
+ box-shadow: 0 0 2px ${({ theme }) => theme.colorPrimaryActive} !important;
+ border-top: 2px;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invisible border due to missing style</b></div>
<div id="fix">
The CSS shorthand 'border-top: 2px;' sets the width but defaults the style
to 'none', preventing any visible border from rendering. Since
'border-top-color' is already set to the theme's primary active color, adding
'solid' to the shorthand will make the intended 2px top border appear for
active tabs.
</div>
</div>
<small><i>Code Review Run #bb862d</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [x] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
