vighneshtule opened a new pull request, #36882:
URL: https://github.com/apache/superset/pull/36882

   ### Description
   Fixes #36876.
   
   ### Summary
   The "Clear All" button in the Native Filters bar previously only reset the 
form UI without dispatching the corresponding updates to the Redux store. This 
left the dashboard in a desynchronized state where the UI appeared empty, but 
the charts remained filtered until the user manually clicked "Apply".
   
   This PR updates `handleClearAll` to explicitly nullify values for all active 
filters and dispatch `updateDataMask` immediately. This ensures consistency 
between the local component state and the global Redux state, triggering the 
necessary dashboard refresh and correctly disabling the "Apply" button.
   
   ### Before/After Screenshots
   **Before:**
   
   
https://github.com/user-attachments/assets/e48c3270-7377-4ab4-911b-c058626d4ef9
   
   
   - "Clear All" reset the input inputs but did not trigger a chart reload.
   - The "Apply" button remained active/enabled, requiring a second click.
   
   **After:**
   
   
https://github.com/user-attachments/assets/3a25313b-f8b2-48d5-88c5-96736ddb8d9b
   
   
   - "Clear All" immediately resets inputs and reloads charts with the 
unfiltered dataset.
   - The "Apply" button is correctly disabled, indicating no pending changes.
   
   ### Testing Instructions
   1.  Open a dashboard with Native Filters.
   2.  Apply a filter value (e.g., Country: Argentina).
   3.  Click "Apply" -> Charts update.
   4.  Click "Clear All".
   5.  **Verify**: Charts reload immediately, and the "Apply" button is 
disabled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to