EnxDev commented on PR #36889: URL: https://github.com/apache/superset/pull/36889#issuecomment-3705984017
> The original issue was that when dragging an active tab it would not show the drag indicator. We have a few possible paths here: > - Show the drag indicator only when dragging has actually started. > - Add an additional dragging area (before or after the tab title) that would indicate to the user that dragging can be done by targeting that specific area - very common pattern. > - Accept that an active tab is also editable and never show the drag indicator (previous behavior) - acceptable but not perfect. > > I think option 1 is viable and option 2 is ideal. > > The change introduced in this PR seems to have an issue for which dragging would not be possible at all if you are hovering the tab text - which is definitely something we don't want. The changes introduced prevent the tab from being dragged when it is selected and the cursor is over the input field. This ensures that the indicator remains visible, making it clear to the user that the text can be edited. Personally, I feel that with the proposed options it may not always be very clear when the tab can be edited versus when it can be moved. To make this behavior clearer, we could consider adding a pencil icon to indicate that the text is editable. This would help clarify the interaction and still allow the user to drag the element by selecting it from the remaining available space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
